Skip to content

fix: Change 'three' to 'tree' in GetRoot exception message #3426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhaysaqi wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −4
Open

fix: Change 'three' to 'tree' in GetRoot exception message #3426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b34c5
fix: Change 'three' to 'tree' in GetRoot exception message
abhaysaqi Dec 1, 2025
51b633e
fix: Add missing type annotation and remove redundant default case - …
abhaysaqi Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/get_navigation/src/root/get_root.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ class GetRootState extends State<GetRoot> with WidgetsBindingObserver {
static GetRootState? _controller;
static GetRootState get controller {
if (_controller == null) {
throw Exception('GetRoot is not part of the three');
throw Exception('GetRoot is not part of the tree');
} else {
return _controller!;
}
Expand Down
5 changes: 2 additions & 3 deletions lib/get_navigation/src/routes/get_router_delegate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,13 +280,12 @@ class GetDelegate extends RouterDelegate<RouteDecoder>
return SynchronousFuture(_canPopPage());
}

bool _canPop(mode) {
bool _canPop(PopMode mode) {
switch (mode) {
case PopMode.history:
return _canPopHistory();
case PopMode.page:
default:
return _canPopPage();
return _canPopPage();
}
}

Expand Down