Fix undefined variables bug when no features selected (ninmax <= 0)#37
Open
bnaul wants to merge 1 commit intojonathan-taylor:mainfrom
Open
Fix undefined variables bug when no features selected (ninmax <= 0)#37bnaul wants to merge 1 commit intojonathan-taylor:mainfrom
bnaul wants to merge 1 commit intojonathan-taylor:mainfrom
Conversation
When ninmax <= 0 (no features selected due to high penalty, all features ineligible, or numerical issues), the variables coefs, intercepts, and df were undefined but referenced in the return statement, causing an error. Added else clause to initialize these variables with zeros when ninmax <= 0, ensuring the method returns valid results in all cases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this when testing a very wide regularization path:
When ninmax <= 0 (no features selected due to high penalty, all features ineligible, or numerical issues), the variables coefs, intercepts, and df were undefined but referenced in the return statement, causing an error.
Added else clause to initialize these variables with zeros when ninmax <= 0, ensuring the method returns valid results in all cases.
🤖 Generated with Claude Code