Skip to content

Prepare for multi-package repository.#264

Merged
jonathanknowles merged 4 commits intomainfrom
jonathanknowles/multi-package-repo
Mar 30, 2025
Merged

Prepare for multi-package repository.#264
jonathanknowles merged 4 commits intomainfrom
jonathanknowles/multi-package-repo

Conversation

@jonathanknowles
Copy link
Owner

No description provided.

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/multi-package-repo branch from 40c3d95 to 36eb67a Compare March 30, 2025 08:08
@jonathanknowles jonathanknowles requested a review from Copilot March 30, 2025 08:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the repository for a multi-package setup through modifications to the GitHub Actions build workflow. Key changes include:

  • Adding a conditional execution for the Documentation (Generation) step based on the operating system and GHC version.
  • Replacing the "cabal haddock" command with "cabal haddock-project" with new flags.
  • Removing the file move command in the Documentation (Staging) step.
Files not reviewed (1)
  • cabal.project: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/build.yml:108

  • The added condition restricts execution to only ubuntu-latest and GHC 9.12. Confirm this is intended for consistent behavior across all intended environments or update the condition accordingly.
if: |
            matrix.os == 'ubuntu-latest'
            && matrix.ghc == '9.12'

.github/workflows/build.yml:121

  • Removing the move command may lead to issues if downstream steps still expect the documentation in the previous build directory location. Verify that 'cabal haddock-project' outputs documentation directly into the 'gh-pages' directory as intended.
mv ${{ env.cabal-build-dir }}/build/*/*/*/doc/html/* gh-pages

@jonathanknowles jonathanknowles merged commit 18c963e into main Mar 30, 2025
22 checks passed
@jonathanknowles jonathanknowles deleted the jonathanknowles/multi-package-repo branch March 30, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants