Prepare for multi-package repository.#264
Merged
jonathanknowles merged 4 commits intomainfrom Mar 30, 2025
Merged
Conversation
40c3d95 to
36eb67a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the repository for a multi-package setup through modifications to the GitHub Actions build workflow. Key changes include:
- Adding a conditional execution for the Documentation (Generation) step based on the operating system and GHC version.
- Replacing the "cabal haddock" command with "cabal haddock-project" with new flags.
- Removing the file move command in the Documentation (Staging) step.
Files not reviewed (1)
- cabal.project: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:108
- The added condition restricts execution to only ubuntu-latest and GHC 9.12. Confirm this is intended for consistent behavior across all intended environments or update the condition accordingly.
if: |
matrix.os == 'ubuntu-latest'
&& matrix.ghc == '9.12'
.github/workflows/build.yml:121
- Removing the move command may lead to issues if downstream steps still expect the documentation in the previous build directory location. Verify that 'cabal haddock-project' outputs documentation directly into the 'gh-pages' directory as intended.
mv ${{ env.cabal-build-dir }}/build/*/*/*/doc/html/* gh-pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.