-
Notifications
You must be signed in to change notification settings - Fork 91
Replace mpsc::{Sender,Receiver} by VecDeque #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
876857e to
f0a6515
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
jonhoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to make this change! And sorry for the slow reply 😅
Just one bit in there that I think is wrong, otherwise looks good 👍
|
Hi @soywod I really like this PR and it also looks super close to being finished. Is there anyway I can help get this merged? |
|
I forgot about this PR as it did not fix my initial issue. I can take a look back during this week and see if I can complete it. |
47a0c4d to
bb60096
Compare
0aa822e to
6bc124f
Compare
|
Sorry for the very long delay. The PR is ready for another review! |
jonhoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! A few instances of one change I'd like to see (I'll just commit those), and otherwise two questions.
For better errors when tests fail
Made Session::unsolicited_responses pub(crate), and renamed Session::all_unsolicited to take_all_unsolicited.
jonhoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, we managed to land it before two years passed 😂
Mostly my fault — thanks for sticking with it!
Fixes #254.
This change is