Skip to content

Conversation

@soywod
Copy link
Collaborator

@soywod soywod commented May 11, 2023

Fixes #254.


This change is Reviewable

@soywod soywod force-pushed the master branch 2 times, most recently from 876857e to f0a6515 Compare May 11, 2023 20:23
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Attention: Patch coverage is 93.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.5%. Comparing base (a7d22f0) to head (2beff59).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parse.rs 93.9% 5 Missing ⚠️
src/client.rs 87.8% 4 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/extensions/list_status.rs 87.8% <100.0%> (ø)
src/extensions/metadata.rs 92.6% <100.0%> (ø)
src/types/acls.rs 98.4% <100.0%> (ø)
src/types/capabilities.rs 55.8% <100.0%> (ø)
src/types/fetch.rs 65.6% <100.0%> (ø)
src/types/name.rs 70.1% <100.0%> (ø)
src/types/quota.rs 93.7% <100.0%> (ø)
src/client.rs 92.7% <87.8%> (-0.1%) ⬇️
src/parse.rs 89.9% <93.9%> (+0.4%) ⬆️

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to make this change! And sorry for the slow reply 😅

Just one bit in there that I think is wrong, otherwise looks good 👍

@bogthe
Copy link

bogthe commented Apr 9, 2024

Hi @soywod I really like this PR and it also looks super close to being finished. Is there anyway I can help get this merged?

@soywod
Copy link
Collaborator Author

soywod commented Apr 10, 2024

I forgot about this PR as it did not fix my initial issue. I can take a look back during this week and see if I can complete it.

@soywod soywod force-pushed the master branch 3 times, most recently from 47a0c4d to bb60096 Compare January 1, 2025 10:34
@soywod soywod force-pushed the master branch 2 times, most recently from 0aa822e to 6bc124f Compare January 1, 2025 10:52
@soywod
Copy link
Collaborator Author

soywod commented Jan 1, 2025

Sorry for the very long delay. The PR is ready for another review!

@soywod soywod requested review from d2weber and jonhoo January 1, 2025 10:54
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! A few instances of one change I'd like to see (I'll just commit those), and otherwise two questions.

jonhoo and others added 3 commits January 5, 2025 09:26
For better errors when tests fail
Made Session::unsolicited_responses pub(crate), and renamed
Session::all_unsolicited to take_all_unsolicited.
@soywod soywod requested a review from jonhoo January 8, 2025 08:41
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, we managed to land it before two years passed 😂
Mostly my fault — thanks for sticking with it!

@jonhoo jonhoo merged commit 6fe22ed into jonhoo:main Jan 21, 2025
19 checks passed
@soywod soywod deleted the master branch January 22, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnsolicitedResponse isn't Send

4 participants