-
-
Notifications
You must be signed in to change notification settings - Fork 82
feat: Claude Desktop configuration support for Linux and Windows #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomasohara
wants to merge
5
commits into
jonigl:main
Choose a base branch
from
tomasohara:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
662dacb
adds support for Linux and Windows
4963e92
adds devel branch; adds MacOS and Windows
a97bc12
adds xfail to test failing under Windows via Github Actions
c621379
changes xfail to platform-specifc skip
03c54f8
adds OS label to test job name
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,10 +1,21 @@ | ||||||
| """Constants used throughout the MCP Client for Ollama application.""" | ||||||
|
|
||||||
| import os | ||||||
| import platform | ||||||
| from mcp.types import LATEST_PROTOCOL_VERSION | ||||||
|
|
||||||
| # Default Claude config file location | ||||||
| DEFAULT_CLAUDE_CONFIG = os.path.expanduser("~/Library/Application Support/Claude/claude_desktop_config.json") | ||||||
| if os.name == 'nt': | ||||||
| # %appdata% typically resolves as C:\Users\<USERNAME>\AppData\Roaming | ||||||
| APPDATA = os.environ['APPDATA'] | ||||||
| CONFIG_DIR = os.path.join(APPDATA, 'Claude', 'claude_desktop_config.json') | ||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This suggestions avoid repeating the filename for the |
||||||
| else: | ||||||
| CONFIG_DIR = ( | ||||||
| os.path.expanduser("~/Library/Application Support/Claude") | ||||||
| if platform.system() != 'Linux' | ||||||
| else os.path.expanduser("~/.config/Claude") | ||||||
| ) | ||||||
| DEFAULT_CLAUDE_CONFIG = os.path.join(CONFIG_DIR, "claude_desktop_config.json") | ||||||
|
|
||||||
| # Default config directory and filename for MCP client for Ollama | ||||||
| DEFAULT_CONFIG_DIR = os.path.expanduser("~/.config/ollmcp") | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using
.getto avoidKeyErrorif the envar is not present. And adding fallback just in case