Skip to content

Resolve #42 -- Add logging and sampling callbacks #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Resolve #42 -- Add logging and sampling callbacks #43

wants to merge 1 commit into from

Conversation

codingjoe
Copy link

@codingjoe codingjoe commented Jul 12, 2025 •
edited
Loading

Please read #42 first.

Ok, I took the liberty and went ahead to cook up a patch to continue the work on my MCP.

Changes

  • Add a logging callback that prints logs into the rich console.
  • Add a sampling callback that executes tasks on the current model.

Open Todos

  • add tests for the new funtions and callbacks
  • add include_context functionality to include MCP servers in the inference run

@codingjoe codingjoe marked this pull request as draft July 12, 2025 17:39
@codingjoe codingjoe force-pushed the issues/42/callbacks branch 3 times, most recently from 0184cef to 550b316 Compare July 12, 2025 18:23
@codingjoe codingjoe force-pushed the issues/42/callbacks branch from 550b316 to 4019b29 Compare July 12, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codingjoe