Minor fixes to standardLibrary.ts #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds groundSpeed and heading to the bound variables list.
It returns a scalar and not a vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds a few missing bound variable names, and fixes a bug with the return type of VectorDotProduct().
What is the current behavior? (You can also link to an open issue here)
The symbols added give a symbol-may-not-exist warning.
VectorDotProduct() indicates a return type of vectorType, different from vdot().
What is the new behavior (if this is a feature change)?
The new symbols will reflect their existence and correct typing.
VectorDotProduct() indicates a return type of scalarType.
Other information:
Merry Christmas!