refactor: use positive lookahead in RegExp#2
Open
noscripter wants to merge 1 commit intojonschlinkert:masterfrom
Open
refactor: use positive lookahead in RegExp#2noscripter wants to merge 1 commit intojonschlinkert:masterfrom
noscripter wants to merge 1 commit intojonschlinkert:masterfrom
Conversation
Since negative lookbehind is relatively new(which got accepted in ECMAScript in 2018) and only v8 and node.js behind v9 without a flag support it, it's more convenient and compatible to use positive lookahead instead. ref: https://stackoverflow.com/questions/641407/javascript-negative-lookbehind-equivalent
Owner
It doesn't do the same thing. Lookahead and lookbehind don't advance the cursor position, as they're "zero-length" assertions. Thus, However, I'm glad you brought this up, I'd like to make the regex more compatible. I'll keep this open to discuss. Perhaps we should add some test cases to make sure it works in different scenarios. |
Owner
|
and thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since negative lookbehind is relatively new(which got accepted in ECMAScript in 2018) and only v8 and node.js behind v9 without a flag support it, it's more convenient and compatible to use positive lookahead instead.
ref: https://stackoverflow.com/questions/641407/javascript-negative-lookbehind-equivalent