fix: unable to import module from typescript

[mleguen]

Allow import in typescript:

import timestamp = require('timestamp');

EDIT: updated with typescript recommanded import syntax for commonjs module as recommanded by @fregante (see below).

[mleguen]

Close #14

[fregante]

That * as timestamp should never be used. Either use import or require

[mleguen]

@fregante Could you be a little more explicit about why it should never be used?

Isn't it the standard typescript way to access a commonjs module's module.export (as in typescript docs])?

[fregante]

That page is for ES Modules, you can use import * as name because ES Modules have multiple exports. Common JS modules only have one import and you should only use require (unless you have the compatibility option enabled). There’s an additional way to require them but I don’t remember exactly when it was used:

import time = require('time')

I think it’s just an old way though

[papb]

import time = require('time')

Interestingly, recently I've seen this form of importing being preferred over all others, see here and here.

[mleguen]

I did not look at the right part of the typescript documentation. Thank you @fregante for pointing this.

The recommanded syntax for commonjs module is indeed:

import time = require('time')

I edited the issue description and fixed the README in the PR.

[luckydrq]

I did not look at the right part of the typescript documentation. Thank you @fregante for pointing this.

The recommanded syntax for commonjs module is indeed:

import time = require('time')

I edited the issue description and fixed the README in the PR.

This is still not corrected because tsc would compile it as follow:

const time_stamp_1 = require("time-stamp");
const dateStr = time_stamp_1.default('YYYY-MM-DD', new Date(time));

Since exports.default is not defined, the code would fail.

[fregante]

This is still not corrected because tsc would compile it as follow:

That's not right. Demo with module: 'commonjs'

import something = require('something') still uses the regular CommonJS pattern and is completely unrelated to ES Modules.

Documentation: https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require

[luckydrq]

So is this PR ready for merge?

[fregante]

The only thing to notice is that this is a breaking change for TypeScript users that aren’t using esModuleInteropt since import from now has to be import = require