Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions app/RemoteSite/Connection.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;
use GuzzleHttp\Psr7\Utils;
use Illuminate\Support\Facades\App;
use Psr\Http\Message\RequestInterface;

Expand Down Expand Up @@ -121,12 +122,33 @@ protected function performHttpRequest(
/** @var Client $httpClient */
$httpClient = App::make(Client::class);

// Send a streamed response to be able to validate the size
$options['stream'] = true;
$options['progress'] = function (
$downloadTotal,
$downloadedBytes
) use ($request) {
if ($downloadedBytes > 1024000) {
throw new \RuntimeException("Unplausible response size while fetchting from " . $request->getUri());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean can not be paused?
==> un-pausable
or do you mean not believable?
==>implausible

}
};

/** @var Response $response */
$response = $httpClient->send(
$request,
$options
);

// Convert the streamed response into a "normal" one
$buffer = '';

while (!$response->getBody()->eof()) {
$buffer .= $response->getBody()->read(8192);
}

// Overwrite streamed body
$response = $response->withBody(Utils::streamFor($buffer));

// Validate response
if (!json_validate((string) $response->getBody())) {
throw new RequestException(
Expand Down