Skip to content

Pass update filename to finalize task #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HLeithner merged 2 commits into from
Jan 7, 2026
Merged

Pass update filename to finalize task #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc5873
pass update filename to finalize task
SniperSister Jan 7, 2026
e1c5c42
cs fix
SniperSister Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/Jobs/UpdateSite.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ public function handle(): void
}

// Run the postupdate steps
$postUpdateResult = $connection->finalizeUpdate(["fromVersion" => $healthResult->cms_version]);
$postUpdateResult = $connection->finalizeUpdate([
"fromVersion" => $healthResult->cms_version,
"updateFileName" => $prepareResult->filename,
]);

if (!$postUpdateResult->success) {
throw new UpdateException(
Expand Down
2 changes: 1 addition & 1 deletion app/RemoteSite/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* @method HealthCheckResponse checkHealth()
* @method GetUpdateResponse getUpdate()
* @method PrepareUpdateResponse prepareUpdate(array<string,string> $data)
* @method FinalizeUpdateResponse finalizeUpdate(array<string,string> $data)
* @method FinalizeUpdateResponse finalizeUpdate(array<string,string|null> $data)
* @method NotificationResponse notificationSuccess(array<string,string> $data)
* @method NotificationResponse notificationFailed(array<string,string> $data)
*/
Expand Down
3 changes: 2 additions & 1 deletion app/RemoteSite/Responses/PrepareUpdate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ class PrepareUpdate extends BaseDTO implements ResponseInterface
{
public function __construct(
public string $password,
public int $filesize
public int $filesize,
public ?string $filename = null
) {
}
}