add default command #5
Open
+81
−797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies the application by migrating from Joomla Console to Symfony Console and implements a default command feature that eliminates the need to specify the command name when running the CLI script.
Key Changes:
- Removed Joomla framework dependencies (joomla/console, joomla/application, joomla/event, joomla/filter, joomla/language, joomla/registry, joomla/string, joomla/utilities)
- Upgraded Symfony Console from v7.4.1 to v8.0.1 and Symfony Dotenv from v7.4.0 to v8.0.0
- Set
github-pr-commentsas the default command, allowing users to run the script without specifying the command name
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| composer.json | Updated dependencies to remove Joomla packages and allow Symfony v7 or v8; simplified package description |
| composer.lock | Reflects removal of Joomla packages and upgrade to Symfony v8 packages with updated content hash |
| cli/github-pr-comments.php | Migrated from Joomla Console to Symfony Console; refactored command class to extend Symfony's Command class and use configure()/execute() pattern; added default command configuration |
| README.md | Updated all command examples to remove the explicit command name, reflecting the new default command behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduction to a default command