Skip to content

[5.0] Add javascript removals from PR #40302 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

[5.0] Add javascript removals from PR #40302 #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f66431
Add javascript removals from PR #40302
richard67 Apr 2, 2023
88f8a94
Small style change
richard67 Apr 2, 2023
16e4ce6
Merge branch '5.0' into 5.0-add-js-removals-to-44-50-removed-backward…
richard67 Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions migrations/44-50/removed-backward-incompatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,19 @@ class MyModel extends ListModel {
### CSS removals
The CSS class ".ie11" was removed [via PR #39018](https://github.com/joomla/joomla-cms/pull/39018)

### Javascript removals
The following Javascript assets were removed [via PR #40302](https://github.com/joomla/joomla-cms/pull/40302):
- `/media/com_templates/js/admin-template-compare.js` - Not used anymore by the core since version 4.3.0, [see PR #38823](https://github.com/joomla/joomla-cms/pull/38823).

- `/media/com_users/js/admin-users-mail.js` - Not used anymore by the core since version 4.3.0, [see PR #39374](https://github.com/joomla/joomla-cms/pull/39374).

This includes also the `-es5.js` files and the minified and gzipped files and the corresponding entries in `joomla.asset.json` files.

The files have been kept in Joomla 4 for b/c with layout overrides.

To fix these layout overrides for Joomla 5, change your layout override in the same way as the corresponding core layout has been changed by the PR mentioned in the list above for each Javascript asset.

Eg for the template manager's side-by-side comparison view, [see PR #38823](https://github.com/joomla/joomla-cms/pull/38823).

### Return Types
All return types have been updated to match the PHP 8.1 return type signatures. This addresses any class utilising the ArrayAccess, Datetime or the JsonSerializable interfaces. If you extend from any of the affected classes and require compatibility with both Joomla 4.x and 5.x you should add the `#[\ReturnTypeWillChange]` annotation to your code.
Expand Down