Skip to content

Commit 8bc4e07

Browse files
authored
Allow to deprecate WebAssets (#40385)
* Log of deprecated WebAssets * deprecated com_templates.admin-template-compare
1 parent 9363e78 commit 8bc4e07

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

build/media_source/com_templates/joomla.asset.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@
2727
],
2828
"attributes": {
2929
"type": "module"
30-
}
30+
},
31+
"deprecated": true,
32+
"deprecatedMsg": "To be removed in Joomla 5.0"
3133
},
3234
{
3335
"name": "com_templates.admin-template-toggle-assignment.es5",

libraries/src/Document/Renderer/Html/ScriptsRenderer.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,13 @@ private function renderElement($item): string
159159
if ($asset->getDependencies()) {
160160
$attribs['data-asset-dependencies'] = implode(',', $asset->getDependencies());
161161
}
162+
163+
if ($asset->getOption('deprecated')) {
164+
@trigger_error(
165+
sprintf('Web Asset script [%s] is deprecated. %s', $asset->getName(), $asset->getOption('deprecatedMsg', '')),
166+
E_USER_DEPRECATED
167+
);
168+
}
162169
}
163170
} else {
164171
$attribs = $item;

libraries/src/Document/Renderer/Html/StylesRenderer.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,13 @@ private function renderElement($item): string
151151
if ($asset->getDependencies()) {
152152
$attribs['data-asset-dependencies'] = implode(',', $asset->getDependencies());
153153
}
154+
155+
if ($asset->getOption('deprecated')) {
156+
@trigger_error(
157+
sprintf('Web Asset style [%s] is deprecated. %s', $asset->getName(), $asset->getOption('deprecatedMsg', '')),
158+
E_USER_DEPRECATED
159+
);
160+
}
154161
}
155162
} else {
156163
$attribs = $item;

0 commit comments

Comments
 (0)