[6.1] Improve Multilanguage::getSiteHomePages()

[Denitz]

Summary of Changes

Joomla\CMS\Language\Multilanguage::getSiteHomePages() uses an extra database query per each page load to discover the language-specific site homepages.

We can easily eliminate this extra database query and use the native SiteMenu::getItems().

Testing Instructions

Test a website with enabled multilanguage functionality and Joomla system caching enabled.

Actual result BEFORE applying this Pull Request

See an extra unoptimized SQL query per each page load:

SELECT `language`,`id` FROM `jos_menu` WHERE `home` = '1' AND `published` = 1 AND `client_id` = 0

Expected result AFTER applying this Pull Request

No extra SQL query, the homepages are discovered from the cached menu items.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[crommie]

I have tested this item ✅ successfully on 9ea35c7

Extra query has gone.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.}

[viocassel]

I have tested this item ✅ successfully on 9ea35c7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.}

[Fedik]

I have tested this item ✅ successfully on b22dc09

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.}

[Fedik]

I set it RTC, it seems was removed by accident and lost in time.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41507.}

[brianteeman]

Is this still relevant as the code for multilingual home pages has changed since this PR was first created

[Fedik]

Yes, method getSiteHomePages still there, and still in use.

[HLeithner]

This pull request has been automatically rebased to 6.1-dev.

[HLeithner]

Thanks, I skipped the deprecation for now, since it's not so important and we need to remove the usages first.

[Fedik]

@Denitz I think we can be need to revert it, because ConsoleApplication does not have getMenu().
Can you please have a look?

Or maybe some extra check for instance of ConsoleApplication

[Denitz]

@Fedik Good catch, here we go: #47310

I returned original code for non-CMSWebApplicationInterface instances because getMenu() is defined in this interface.

[HLeithner]

Actually @joomdonation found this issue.
As I wrote in your PR we will revert this and only keep the new code in the menu and deprecate the getSiteHomePages() and remove it in joomla 8.0. and rewrite all usages to the $menu->getHomepages() method.

Can you do this?