[5.1] Complete com_search deprecation #40727

[brianteeman]

@hackware deprecated various search methods in libraries/src/Language/Language.php in #40727

This PR completes that PR by deprecating their use in the localise.php file

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

it's too late to deprecated anything in 4.4, that's only allowed in x.y.0 releases. In this case I would deprecate it with 5.1 and remove it with 7.0

[brianteeman]

its a bug that @Hackwar forgot to deprecate it when he deprecated the code and now removes the actual code with #42892. If this can't be deprecated until 5.1 then the code itself will have to stay al;so until 7. Anything else makes no sense

[ceford]

I have tested this item ✅ successfully on 51255d3

I looked at the code and read the comments so it looks OK to me as a bug fix for a previous commit.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.}

[laoneo]

@brianteeman then we have to change these depreciations you are talking about to 7.0 as well. Better to follow our deprecation policy and postpone already added deprecations than vice versa.

[brianteeman]

fine by me

[laoneo]

@brianteeman can you rebase this one to 5.1-dev, so we can merge it.

[laoneo]

I have tested this item ✅ successfully on f7ac86b

Doc blocks are correct

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891.}

[brianteeman]

@laoneo I did what you asked and rebased it. Any reason why it cant be merged now?

[laoneo]

This is up to @bembelimen or @LadySolveig as they are the RM.

[Hackwar]

This is now also to late for 5.1, so it would have to go into 5.2-dev

[brianteeman]

I am not remaking it. Someone else can fix your mistake. The pr was made and tested in good time.

[LadySolveig]

Thank you @brianteeman and for review @ceford and @laoneo

[brianteeman]

thanks - appreciate it