[6.1] make media action crop aspect ratio configurable

[hans2103]

Pull Request for no issue

Summary of Changes

This PR will add a subform to plugin media-action/crop to give you the option to configure your own aspect-ratios.
With this PR merged I am able to create a own set of aspect ratios.

Testing Instructions

• Go To System > Plugins > Media-Action = Crop and notice the lack of options

• Go To Content > Media ... select the three dots of an image and press "Edit". Open the dropdown at Aspect-Ratio and notice the presence of a pre-defined set of aspect-ratios

• Apply the PR

• npm run build:js to compile newly added js

• Go To System > Plugins > Media-Action = Crop and notice the availability of an aspect-ratio-calculator and a subform to add / remove / edit aspect-ratio options. Add, remove and edit aspect ratios.

• Save the changes

• Go To Content > Media ... select the three dots of an image and press "Edit". Open the dropdown at Aspect-Ratio and notice the changed set of aspect ratios

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Thank you for fixing those errors

[RickR2H]

I have tested this item ✅ successfully on d79e1f7

Test by code review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46421.}

[exlemor]

Sadly, @hans2103 when applying Download package on Joomla 6.1 Nightly downloaded 30 minutes ago on PHP 8.4.15, I get:

An error has occurred.
0 Error loading form file

(changed to PHP 8.3 and same result ;()

Testing process:

Fresh Nightly install,
Sample Blog Data,
French language file,
Multilanguage Data,
Regular Labs Cache Cleaner
Joomla Patch Tester 5.0.0

Checked BEFORE condition of PR which were a match
Download PR package and then went to check Media - Crop plugin ;(

[richard67]

@hans2103 System tests would need some adjustment for this PR.

See https://github.com/joomla/joomla-cms/actions/runs/19510792565/job/55849853256?pr=46421 :

Running:  install/Installation.cy.js                                                    (1 of 148)

  Install Joomla
    1) "after each" hook for "Install Joomla"

  0 passing (14s)
  1 failing

  1) Install Joomla
       "after each" hook for "Install Joomla":
     CypressError: `cy.task('checkForLogs')` failed with the following error:

> [Wed Nov 19 17:43:33.751743 2025] [php:warn] [pid 263:tid 263] [client 127.0.0.1:47700] PHP Warning:  simplexml_load_file(): /tests/www/cmaria/plugins/media-action/crop/crop.xml:72: parser error : Opening and ending tag mismatch: fieldset line 25 and field in /tests/www/cmaria/libraries/src/Installer/Installer.php on line 2116, referer: https://localhost/cmaria/installation/index.php

And later those fail:

plugins/media-action/crop/CropPlugin.cy.js
plugins/media-action/resize/ResizePlugin.cy.js
plugins/media-action/rotate/RotatePlugin.cy.js

[brianteeman]

The system tests are correct!

[brianteeman]

@exlemor you are correct. The XML is wrong as identified by the system tests

[TLWebdesign]

Correction; the closing tag on line 39 is wrong it seems. although that doesn't fix the form completely if i change only that. Could be my install now but the calculator is broken atm. it just shows as a text field.

[hans2103]

@hans2103 System tests would need some adjustment for this PR.

See https://github.com/joomla/joomla-cms/actions/runs/19510792565/job/55849853256?pr=46421 :

Running:  install/Installation.cy.js                                                    (1 of 148)

  Install Joomla
    1) "after each" hook for "Install Joomla"

  0 passing (14s)
  1 failing

  1) Install Joomla
       "after each" hook for "Install Joomla":
     CypressError: `cy.task('checkForLogs')` failed with the following error:

> [Wed Nov 19 17:43:33.751743 2025] [php:warn] [pid 263:tid 263] [client 127.0.0.1:47700] PHP Warning:  simplexml_load_file(): /tests/www/cmaria/plugins/media-action/crop/crop.xml:72: parser error : Opening and ending tag mismatch: fieldset line 25 and field in /tests/www/cmaria/libraries/src/Installer/Installer.php on line 2116, referer: https://localhost/cmaria/installation/index.php

And later those fail:

plugins/media-action/crop/CropPlugin.cy.js
plugins/media-action/resize/ResizePlugin.cy.js
plugins/media-action/rotate/RotatePlugin.cy.js

the issue was caused by commit d79e1f7
I have reverted it.

[brianteeman]

Sorry I must have been incorrect. Clearly when there is a subform you dont close the field as I had assumed

[brianteeman]

When in dark mode you can never see the calculated value and the button is hard to see

I think this is caused by an already reported bug with the dark mode css when used in alerts

[brianteeman]

The Calculated value doesnt use the same "rounding" as the default settings. Just seems odd/confusing/unexpected

[brianteeman]

Default aspect ratio appear to be the calculated ratio of the original image so wouldnt it be more accurate to call it "original" and not "default" as I was looking for somewhere to set a "default" value thinking it would be defined somewhere globally

How is setting the ratio to default any different to none

[hans2103]

When in dark mode you can never see the calculated value and the button is hard to see

I think this is caused by an already reported bug with the dark mode css when used in alerts

Solved issue with commit c76424f

[hans2103]

Default aspect ratio appear to be the calculated ratio of the original image so wouldnt it be more accurate to call it "original" and not "default" as I was looking for somewhere to set a "default" value thinking it would be defined somewhere globally

How is setting the ratio to default any different to none

@brianteeman I don't know... out of scope for my PR. That has been the case for the last 7 years already
See commit 145da22 by @laoneo

[hans2103]

The Calculated value doesnt use the same "rounding" as the default settings. Just seems odd/confusing/unexpected

The initial values where copied from the original. The original values where hard coded.

• 2:3 was written as 0.6666666666666667
• 16:9 was written as 1.7777777777777777

I do not think that the default settings are rounded... otherwise 16:9 would have been rounded to 1.7777777777777778

with commit f751bd2 I have adjusted the default settings. No more odd / confusing / unexpected behavior and the same output as the calculator

[brianteeman]

Thanks.

I admit I never used it before as I have an odd ratio on my site. Now I can use it.

I still think default and none are confusing

[hans2103]

Thanks.

I admit I never used it before as I have an odd ratio on my site. Now I can use it.

I still think default and none are confusing

I do agree on the confusing part, but that is out of scope of this PR.

[TLWebdesign]

on dark mode the button outline becomes "invisible" because you have succes on succes with same color. Maybe change the copy button to btn-primary?

[TLWebdesign]

I have tested this item ✅ successfully on 0a2c785

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46421.}