Skip to content

[6.1] Expand useGlobal to also use plugin parameters #46439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 6.1-dev
Choose a base branch
from
+27 −7
Open

[6.1] Expand useGlobal to also use plugin parameters #46439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
146b36f
Expand useGlobal to also use plugin parameters
Ruud68 Nov 11, 2025
fb66bf3
satisfy php-cs-fixer
Ruud68 Nov 11, 2025
70ecc62
Expand useGlobal to also specify which component parameters to use
Ruud68 Nov 19, 2025
c835545
satisfy php-cs-fixer
Ruud68 Nov 20, 2025
63c4231
satisfy php-cs-fixer
Ruud68 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions joomla-cms
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
joomla-cms
Copy link
Member

@laoneo laoneo Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this here looks wrong

Copy link
Contributor Author

@Ruud68 Ruud68 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea where you get that from: all checks have passed is what it is telling me?

33 changes: 26 additions & 7 deletions libraries/src/Form/Field/TextField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
use Joomla\CMS\Form\FormField;
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Plugin\PluginHelper;
use Joomla\CMS\Uri\Uri;
use Joomla\Registry\Registry;

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
Expand Down Expand Up @@ -218,16 +220,33 @@ public function setup(\SimpleXMLElement $element, $value, $group = null)
protected function getInput()
{
if ($this->element['useglobal']) {
$component = Factory::getApplication()->getInput()->getCmd('option');
if (str_starts_with((string) $this->element['useglobal'], 'com_')) {
// Get the correct component parameters
$params = ComponentHelper::getParams((string) $this->element['useglobal']);
} elseif (substr_count((string) $this->element['useglobal'], '_') === 2) {
// Get the correct plugin parameters
[$prefix, $type, $plugin] = explode('_', (string) $this->element['useglobal'], 3);

if ($prefix === 'plg' && PluginHelper::isEnabled($type, $plugin)) {
$plugin = PluginHelper::getPlugin($type, $plugin);
$params = new Registry($plugin->params);
}
}

if (!isset($params)) {
// Fallback for B/C
$component = Factory::getApplication()->getInput()->getCmd('option');

// Get correct component for menu items
if ($component === 'com_menus') {
$link = $this->form->getData()->get('link');
$uri = new Uri($link);
$component = $uri->getVar('option', 'com_menus');
}

// Get correct component for menu items
if ($component === 'com_menus') {
$link = $this->form->getData()->get('link');
$uri = new Uri($link);
$component = $uri->getVar('option', 'com_menus');
$params = ComponentHelper::getParams($component);
}

$params = ComponentHelper::getParams($component);
$value = $params->get($this->fieldname);

// Try with global configuration
Expand Down