-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.1] UX Improvement Show language override status and quick-create missing overrides #46559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
[6.1] UX Improvement Show language override status and quick-create missing overrides #46559
Conversation
|
I find the use of the terms Translated/Not Translated confusing as the strings are translated they are just not overriden |
Co-authored-by: Brian Teeman <[email protected]>
yes first I used "Associations", but they are not "Associations", so I thought Translated / Not Translated, because in fact if the language keys do not exist in another ini because they are used "custom" they are not translated then. For example you could insert FIELDS_LABEL_TEST into a Fields label and then create language overrides for it. |
|
will check the codestyle! |
|
I have tested this item ✅ successfully on 81aebe2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46559. |
but if they do exist then they are already translated they are just not overriden/customised |
|
i do see this as a useful improvement |
What about Existing Override / Not Existing Override ? It's a bit long but no other idea right now |
….php Co-authored-by: Richard Fath <[email protected]>
|
Sorry for the wrong Commit Message. The table header are now "Override" and "No Override". |
|
I have tested this item ✅ successfully on 6c79b31 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46559. |
|
I have tested this item ✅ successfully on 6c79b31 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46559. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46559. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46559. |
|
@coolcat-creations We have tested it too. It is working and we have a question. If not translated and clicked the warning badge; the create form target is prefilled with the actual language source text. Is it not more useful to have the destination source text presented to override? For example with German override and no override in es-ES:
|
|
@muhme Clicking an existing override opens the correct source file and the correct source language (since it’s already configured). Clicking a badge where no override exists creates/opens an override in the language you came from. This is useful because you get the original text as a blueprint right in front of you—including placeholders and potentially tags—so it’s much easier to translate. And if you use a browser plugin that can translate text in a textarea, you can just select the text and translate it into the desired language. I hope this behavior is accepted. |
|
@coolcat-creations Everything is fine if the actual source text is to be pre-filled. Thank you for the explanation. |
|
Thank you everyone for testing, I am very excited about this feature, it will help to clean some chaos :-) |

Summary of Changes
— Collect overrides for all installed languages (per client) once per load and expose them to the overrides list view.
— Add two columns: Translated (per-language badges for existing overrides) and Not translated (badges to create missing overrides), showing language codes with quick edit/create links.
— Prefill the add form with the source constant/text when creating a missing override via a badge, while preserving filter context on redirects.
Testing Instructions
index.php?option=com_languages&view=overrides, pick a language/client; ensure the Translated and Not translated columns appear.Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Documentation link for docs.joomla.org: Happy to provide a documentation when merged!
[] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed