Skip to content

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Dec 27, 2025

Pull Request for Issue #46582 .

Summary of Changes

If a user defines an own image-class for intro_image or full_image, it is now set before the module classes.

Testing Instruction

see #46582
In an article, add a into or full-image and add an image-class, for example "border border-dark".
Make a module mod_articles where this article is included. Then inspect the code of the image in this module.

Actual result BEFORE applying this Pull Request

The user defined image-class "border border-dark" is ignored.

Expected result AFTER applying this Pull Request

Example:
grafik

The user defined image-class "border border-dark" is accepted.

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst chmst added the bug label Dec 27, 2025
@chmst chmst changed the title [5.] Accept user input in image class. [5.4] Accept user input in image class. Dec 27, 2025
@exlemor
Copy link

exlemor commented Dec 27, 2025

Hi @chmst, I could be doing something wrong but I'm not matching the BEFORE condition (or I misunderstood it)

I took a sample multilingual joomla 5.4 nightly installation and added to 'Article (en-gb)' the Banners Sky image as Intro image and set the class 'border border-dark', saved and added to the user.css this css rule: .border.border-dark {width:50%;} and then went to the front-end (cleared cache) and the CSS was accepted/handled, the image is 50% width... what did I miss?

@brianteeman
Copy link
Contributor

@exlemor display the article in the article module

@chmst
Copy link
Contributor Author

chmst commented Dec 27, 2025

@exlemor sorry, my test instruction needs an enhancment

@exlemor
Copy link

exlemor commented Dec 27, 2025

I have tested this item ✅ successfully on 2b45a68

I have successfully tested this PR - helps when you don't miss a step (thanks @brianteeman).

THANK YOU @chmst for yet another fix ;) Happy Holidays!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 2b45a68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 30, 2025
@richard67 richard67 added this to the Joomla! 5.4.3 milestone Jan 2, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

✅ Final test before merge with JBT

  • Seen the problem before PR, article view displays custom image class settings for intro and full image, but not in Articles module
  • Applied PR with gh pr checkout 46619
  • Intro and full images are shown with custom image class settings in Articles module

@muhme muhme merged commit 63c9360 into joomla:5.4-dev Jan 8, 2026
69 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 8, 2026
@muhme
Copy link
Contributor

muhme commented Jan 8, 2026

Thank you @chmst for your contribution. Thank you @brianteeman for support. Thank you @exlemor and @tecpromotion for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants