-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.4] Accept user input in image class. #46619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @chmst, I could be doing something wrong but I'm not matching the BEFORE condition (or I misunderstood it) I took a sample multilingual joomla 5.4 nightly installation and added to 'Article (en-gb)' the Banners Sky image as Intro image and set the class 'border border-dark', saved and added to the user.css this css rule: .border.border-dark {width:50%;} and then went to the front-end (cleared cache) and the CSS was accepted/handled, the image is 50% width... what did I miss? |
|
@exlemor display the article in the article module |
|
@exlemor sorry, my test instruction needs an enhancment |
|
I have tested this item ✅ successfully on 2b45a68 THANK YOU @chmst for yet another fix ;) Happy Holidays! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619. |
|
I have tested this item ✅ successfully on 2b45a68 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46619. |
|
✅ Final test before merge with JBT
|
|
Thank you @chmst for your contribution. Thank you @brianteeman for support. Thank you @exlemor and @tecpromotion for testing. |
Pull Request for Issue #46582 .
Summary of Changes
If a user defines an own image-class for intro_image or full_image, it is now set before the module classes.
Testing Instruction
see #46582
In an article, add a into or full-image and add an image-class, for example "border border-dark".
Make a module mod_articles where this article is included. Then inspect the code of the image in this module.
Actual result BEFORE applying this Pull Request
The user defined image-class "border border-dark" is ignored.
Expected result AFTER applying this Pull Request
Example:

The user defined image-class "border border-dark" is accepted.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed