[5.4] Fix: Parent menu items missing when creating menu item via 'save to menu'

[hiteshm0]

Pull Request for Issue #46472

Summary of Changes

When creating a menu item via "save to menu" from articles or categories, the menu type is preselected on page load. But, the parent item dropdown does not have any items. This is because the parent item dropdown is populated only when a change event is fired on a menu type field. And no change event occurs when the page is loaded with a preselected menu item.

Fix: Added initialization logic to check if a menu type is already selected on page load. If yes, then the onChange function is trigerred manually.

Testing Instructions

1. Go to content → articles/categories
2. Open/create any article/category
3. Click save to menu button
4. Check the parent item dropdown

Actual result BEFORE applying this Pull Request

Parent Item dropdown is empty

Expected result AFTER applying this Pull Request

Parent item dropdown has the correct items

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ceford]

I have tested this item ✅ successfully on 9e64196

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46621.}

[coolcat-creations]

I have tested this item ✅ successfully on 8110997

Works as described and is very useful, thank you!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46621.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46621.}

[muhme]

✅ Final test before merge with JBT

• It was difficult for me to reproduce the issue, but finally (perhaps after setting ‘Error Reporting’ to system default and disabling ‘Debug System’ and ‘Log Almost Everything’) I was able to reproduce the issue and saw that the list of parent menu items was empty and the suggested workaround of selecting a different menu was also reproduced.
• PR installed with patch tester and npm run build:js
• Successfully verified that the list of menu entries is loaded (in 'Save to Menu' for articles and in both 'Save to Menu as List' and 'Save to Menu as Blog' for categories). The list of parent menu items is always loaded with the correct entries.

[muhme]

Thank you @hiteshm0 for your contribution. Thank you @ceford and @coolcat-creations for testing.

[heelc29]

@richard67 I think this PR is responsible for the recent failed system tests. I haven't investigated this further yet.

[richard67]

@richard67 I think this PR is responsible for the recent failed system tests. I haven't investigated this further yet.

@heelc29 I think the same, but I also have not had time to investigate yet.

[richard67]

It seems this PR was not the right fix. Meanwhile there is a new one, see #46681 .

[hiteshm0]

sorry y'all 😅