Skip to content

[5.4] mod_articles conditional readmore#47263

Merged
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:readmore
Mar 5, 2026
Merged

[5.4] mod_articles conditional readmore#47263
muhme merged 2 commits intojoomla:5.4-devfrom
brianteeman:readmore

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Feb 28, 2026

Pull Request resolves #47260.

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Only show the readmore if there is something more to read

Testing Instructions

Create two articles. One with a readmore and one without a readmore
Create a module-articles to display these articles AND make sure you set to display introtext and readmore

image

Actual result BEFORE applying this Pull Request

Read more link is always displayed
image

Expected result AFTER applying this Pull Request

Read more link is only displayed if there is something to read more
image

Note

The issue is for 6.0 but as this module is intended to replace the existing content modules this is unexpected behaviour and I woujld call this a bug - hence I made the pr against 5.4

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@richard67
Copy link
Member

Create two articles. One with a readmore and one with a readmore

@brianteeman Sure 2 times the same?

@brianteeman
Copy link
Contributor Author

@richard67 oops typo - i have updated the instructions

@dautrich
Copy link

dautrich commented Mar 1, 2026

I have tested this item ✅ successfully on 3b88644


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47263.

1 similar comment
@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 3b88644


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47263.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47263.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2026
@muhme
Copy link
Contributor

muhme commented Mar 5, 2026

✅ Final test before merge using JBT

  • Seen problem before PR
  • Applied PR with Patch Tester
    • Articles without ‘Read more’ no longer display the ‘Read more’ button.
    • Articles with ‘Read more’ continue to display the ‘Read more’ button, which also works.

@muhme
Copy link
Contributor

muhme commented Mar 5, 2026

Thank you @brianteeman for your contribution. Thanky you @richard67 for supporting this PR. Thank you @dautrich and @LadySolveig for testing.

@muhme muhme merged commit 6fc8f6c into joomla:5.4-dev Mar 5, 2026
70 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 5, 2026
@brianteeman brianteeman deleted the readmore branch March 5, 2026 11:35
@richard67 richard67 added this to the Joomla! 5.4.4 milestone Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module "Articles" shows "read more" always and not depending if article has "read more"

7 participants