Fix: Mail template editor Styling(#47292)#47302
Open
Deepcode007 wants to merge 1 commit intojoomla:6.1-devfrom
Open
Fix: Mail template editor Styling(#47292)#47302Deepcode007 wants to merge 1 commit intojoomla:6.1-devfrom
Deepcode007 wants to merge 1 commit intojoomla:6.1-devfrom
Conversation
Contributor
|
This is only fixing a symptom of the original error |
Author
|
Hey @brianteeman, as you mentioned in comment that it was caused due to the height and width being removed from Or would you expect any other solution? Could you please elaborate that. |
Member
|
@Deepcode007 PR #47305 should fix the issue |
Author
|
Okay Rick, shall I close this PR then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #47292 .
Summary of Changes
In the Mail Templates edit view
com_mails, there are two editor fields: a plain text "Body" field and a rich text "HTML Body" field.Previously, the plain text
<textarea>(and the HTML Body<textarea>when the editor is toggled off) had no explicit width defined. This caused them to fall back to the browser's default narrowcolsbehavior, leaving them much narrower than their Bootstrapcol-md-9container and creating layout inconsistency.This PR adds the
width="100%"attribute to both thebodyandhtmlbodyfields in thecom_mails(template.xml)(file:administrator/components/com_mails/forms/template.xml) form definition. Joomla's [EditorField (file:libraries/src/Form/Field/EditorField.php) safely parses this string attribute and passes it to the editor plugins (None, TinyMCE, CodeMirror), which apply it as an inlinestyle="width: 100%;"to ensure the text areas expand gracefully to fill their containers.Testing Instructions
Actual result BEFORE applying this Pull Request
Screen.Recording.2026-03-05.at.2.28.06.AM.mov
Expected result AFTER applying this Pull Request
Screen.Recording.2026-03-05.at.2.29.44.AM.mov
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed