Skip to content

[6.1] Fix none/codemirror editor width and height #47305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RickR2H wants to merge 7 commits into
base: 6.1-dev
Choose a base branch
from
+22 −1
Open

[6.1] Fix none/codemirror editor width and height #47305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09153a2
Fix none / codemirror editor width and height
RickR2H Mar 5, 2026
30f258a
Merge branch '6.1-dev' into fix-none-editor
RickR2H Mar 5, 2026
075f2fa
Plugin specific implementation of the width and height fallback. Rese…
RickR2H Mar 5, 2026
4a1d39d
Merge branch 'fix-none-editor' of github.com:RickR2H/joomla-cms into …
RickR2H Mar 5, 2026
a1b5370
Fix code style
RickR2H Mar 5, 2026
1edd018
Fix code indetation
RickR2H Mar 5, 2026
e09f5be
Move logic for width and height. Added missing default value for width
RickR2H Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plugins/editors/codemirror/src/Provider/CodeMirrorProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ public function display(string $name, string $content = '', array $attributes =
$asset = $params['asset'] ?? 0;
$author = $params['author'] ?? 0;

if (!$width && !$col) {
$width = '100%';
}

if (!$height && !$row) {
$height = '500px';
}

// Must pass the field id to the buttons in this editor.
$buttonsStr = $this->displayButtons($buttons, ['asset' => $asset, 'author' => $author, 'editorId' => $id]);

Expand Down
8 changes: 8 additions & 0 deletions plugins/editors/none/src/Provider/EditorNoneProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ public function display(string $name, string $content = '', array $attributes =
$author = $params['author'] ?? 0;
$readonly = !empty($params['readonly']) ? ' readonly disabled' : '';

if (!$width && !$col) {
$width = '100%';
}

if (!$height && !$row) {
$height = '500px';
}

if (!$id) {
$id = $name;
}
Expand Down
7 changes: 6 additions & 1 deletion plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ public function display(string $name, string $content = '', array $attributes =
$externalPlugins = [];
$theme = 'silver';

// Reset the old default 750px width of the editor to 100%
if (!$width || $width === '750px' || $width === '750') {
Copy link
Member

@richard67 richard67 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should become obsolete if PR #47326 gets accepted.

$width = '100%';
}

// Register assets
$wa->getRegistry()->addExtensionRegistryFile('plg_editors_tinymce');

Expand Down Expand Up @@ -531,7 +536,7 @@ public function prepareTinyMCEUploadPath(string $path): string
'image_caption' => true,
'importcss_append' => true,
'height' => $this->params->get('html_height', '550px'),
'width' => $this->params->get('html_width', ''),
'width' => $this->params->get('html_width', '100%'),
'elementpath' => (bool) $levelParams->get('element_path', true),
'resize' => $resizing,
'external_plugins' => empty($externalPlugins) ? null : $externalPlugins,
Expand Down