Fix accessibility issue with Back-to-Top link#47307
Open
ankushx01-dev wants to merge 1 commit intojoomla:5.4-devfrom
Open
Fix accessibility issue with Back-to-Top link#47307ankushx01-dev wants to merge 1 commit intojoomla:5.4-devfrom
ankushx01-dev wants to merge 1 commit intojoomla:5.4-devfrom
Conversation
Added role="button" attribute to the Back-to-Top link in the Cassiopeia template to improve accessibility and resolve Axe DevTools warning. Fixes joomla#45679
5 tasks
Contributor
|
why add a role to change the semantic meaning of an BUT please note that either with or without that change does not mean it is correct. Passing an automated test does not mean it is correct it just means you passed a test. Have you researched accessibility best practices for back-to-top links and followed their advice or did you just rely on passing a test |
Author
|
Thank you for the feedback. I understand that adding role="button" to an anchor element may not be the correct semantic approach. I will review accessibility best practices for back-to-top links and update the implementation accordingly instead of relying only on the Axe DevTools warning. I will update the PR shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added role="button" attribute to the Back-to-Top link in the Cassiopeia template to improve accessibility and resolve Axe DevTools warning.
Fixes #45679
Pull Request resolves #45679.
Summary of Changes
Added role="button" attribute to the Back-to-Top link in the Cassiopeia template (templates/cassiopeia/index.php) to improve accessibility and address Axe DevTools warnings.
Testing Instructions
Actual result BEFORE applying this Pull Request
The Back-to-Top link does not contain the role="button" attribute, which triggers an accessibility warning in Axe DevTools.
Expected result AFTER applying this Pull Request
The Back-to-Top link includes role="button", improving accessibility and resolving the Axe DevTools warning.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed