Add is_short method #580
Merged
Add is_short method #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
reviewed
Nov 13, 2025
Contributor
Author
Gonna have to look into that I don't really know anything about the test framework/whatever is being used |
Contributor
Author
|
Only failing test is not one I made and it has this error: |
joostlek
reviewed
Nov 13, 2025
Contributor
Author
|
Oh yea I totally didn't copy code.... |
joostlek
approved these changes
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add a method to the
Youtubeclass to check if a video is a youtube short.Have not implemented any tests + some other tests currently aren't passing, probably because of some yt internal changes.
Related Issues
(discussion)
https://github.com/orgs/home-assistant/discussions/1219