fix: update GitHub Actions to use Node 18 and latest action versions #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`actions/setup-node@v1` without a pinned node-version resolves to Node 10, which rejects the `--openssl-legacy-provider` flag used in the build script (exit code 9), breaking all CI/CD workflows.
npm 9+ (bundled with Node 18) enforces strict peer dependency resolution by default. The project has a peer conflict between ts-jest@27 and @types/jest@27 that requires --legacy-peer-deps to resolve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutfrom v2 to v4 andactions/setup-nodefrom v1 to v4 across all workflows (ci, cd, coverage)node-version: 18to prevent runner default (Node 10) from being used--openssl-legacy-provider is not allowed in NODE_OPTIONS(exit code 9)Context
actions/setup-node@v1without anode-versionfield resolves to whatever Node version is pre-installed on the runner (currently Node 10.24.1). The project's build script usesNODE_OPTIONS=--openssl-legacy-provider, which is only supported in Node 17+. This causes every workflow to fail duringnpm install(via thepreparescript).Test plan