Skip to content

Fix: Resolve code folding conflict on mobile (#120)#136

Open
imshubham22apr-gif wants to merge 1 commit intojoplin:masterfrom
imshubham22apr-gif:fix/issue-120-code-folding-mobile
Open

Fix: Resolve code folding conflict on mobile (#120)#136
imshubham22apr-gif wants to merge 1 commit intojoplin:masterfrom
imshubham22apr-gif:fix/issue-120-code-folding-mobile

Conversation

@imshubham22apr-gif
Copy link
Copy Markdown

This PR resolves the issue where the code folding feature in the "Extended Markdown editor settings" plugin would stop working on mobile when this templates plugin was installed.

Changes:

  • Implemented lazy loading for the mobile CommandsPanel. The panel is no longer automatically initialized on startup.
  • Registered a 'showTemplatesPanel' command and added a menu item under 'Tools' to allow manual panel activation.
  • Added a 'created' flag to CommandsPanel to prevent redundant initializations.

Fixes #120.

Copy link
Copy Markdown
Collaborator

@alondmnt alondmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @imshubham22apr-gif . We weren't able to reproduce the issue on Android. Could you explain why you think the commands panel creation interferes with code folding? The panel runs in an isolated webview, so it's not clear how it would affect the editor. Understanding the root cause would help us evaluate the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kills code folding in another plugin

2 participants