Back up review file before upload#14
Open
rmloveland wants to merge 1 commit intojordanlewis:masterfrom
Open
Conversation
This change does the dumbest thing possible: make a backup of the review file with a .bak extension before attempting to push it back up to Github. This addresses the main concern expressed in jordanlewis#10, which is that under the current behavior if the API call to Github fails, the temp file *still gets deleted*, and you can lose a lot of work.
Owner
|
Will this lead to a lot of If you add a thing that deletes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does the dumbest thing possible: make a backup of the review
file with a .bak extension before attempting to push it back up to
Github.
This addresses the main concern expressed in #10, which is that under
the current behavior if the API call to Github fails, the temp
file still gets deleted, and you can lose a lot of work.