Skip to content

getwindowname and search --name are not coherent #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finkandreas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

getwindowname and search --name are not coherent #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 9 additions & 19 deletions xdo_search.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,33 +91,23 @@ static int _xdo_match_window_name(const xdo_t *xdo, Window window, regex_t *re)
* match in _xdo_match_window_classname. But really, most of the time 'name'
* refers to the window manager name for the window, which is displayed in
* the titlebar */
int i;
int count = 0;
char **list = NULL;
XTextProperty tp;


XGetWMName(xdo->xdpy, window, &tp);
if (tp.nitems > 0) {
//XmbTextPropertyToTextList(xdo->xdpy, &tp, &list, &count);
Xutf8TextPropertyToTextList(xdo->xdpy, &tp, &list, &count);
for (i = 0; i < count; i++) {
if (regexec(re, list[i], 0, NULL, 0) == 0) {
XFreeStringList(list);
XFree(tp.value);
int name_type;
int nitems;
unsigned char *name=0;
xdo_get_window_name(xdo, window, &name, &nitems, &name_type);
if (nitems > 0) {
if (regexec(re, (char*)name, 0, NULL, 0) == 0) {
XFree(name);
return True;
}
}
} else {
/* Treat windows with no names as empty strings */
if (regexec(re, "", 0, NULL, 0) == 0) {
XFreeStringList(list);
XFree(tp.value);
XFree(name);
return True;
}
}
XFreeStringList(list);
XFree(tp.value);
XFree(name);
return False;
} /* int _xdo_match_window_name */

Expand Down