This repository was archived by the owner on Jun 16, 2024. It is now read-only.
Open
Conversation
BenjaminP-GitHub
changed the title
Owner
|
Thanks @BenjaminP-GitHub Yeah, if these messages update the statecode then I think other fake message executors should also implement it to be consistent with the state of a real CDS / CRM environment after executing these. So Yes to both questions in my opinion, and so existing executors might need to be revisited so. |
…ty; update CloseQuoteRequest to be consistent
Author
|
@jordimontana82 I've implemented the Quote statecode update and the QuoteClose activity creation for both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the
WinQuoteRequestSDK Message. Implemented to mirror the already implementedCloseQuoteRequestExecutor.Questions:
statecodetoWonalso be implemented in the executor? Currently similar executors do not, so I have omitted it.QuoteCloserecord also be implemented in the executor? Similar ones do not currently.