Add node:util.styleText to benchmark#109
Merged
jorgebucaran merged 1 commit intojorgebucaran:mainfrom Oct 3, 2025
Merged
Conversation
Owner
|
Thank you! Let's merge here and take care of the other issue separately as noted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Node
util.styleTextbenchmark to compare the performance ofnode:util.styleText.util.styleTextis stable from:v23.5.0,v22.13.0.I think it's a worthwhile addition to the benchmark to compare to the node built in.
In order to benchmark this change I have also updated the benchmark node version to 22 which is the latest LTS version. Without changing the bench node version
util.styleTextis not available. Node.js 16 is past it's EOL, either way. Happy to do a seperate pr for that change if preferred