Add placeholder function so executing scripts with inbuilt unit tests don't error#65
Open
t-nil wants to merge 2 commits intojorgebucaran:mainfrom
Open
Add placeholder function so executing scripts with inbuilt unit tests don't error#65t-nil wants to merge 2 commits intojorgebucaran:mainfrom
t-nil wants to merge 2 commits intojorgebucaran:mainfrom
Conversation
Owner
|
Could you clarify what you mean when you say the functions would no longer work in the newly spawned shell? As far as I am concerned, Fishtape has been functioning correctly for at least the past three years. Has something changed or broken? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems also, that your current form of creating these functions (@test, @echo) in
fishtapeandstring collecting them into the newly spawned shell wouldn't work anymore, because you erase those functions globally. Maybe putting them in a special file.Or actually, just making them available to the user, ergo moving them to
functions/@{echo,test}.fishwould also be totally acceptable from my perspective. They interfere with global function space anyway. Then an env could be added to check if the script is called byfishtape.What do you think?