This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Parse PrimitiveLogicalType::Unknown as Arrow Null DataType#1563
Open
jaychia wants to merge 3 commits intojorgecarleitao:mainfrom
Open
Parse PrimitiveLogicalType::Unknown as Arrow Null DataType#1563jaychia wants to merge 3 commits intojorgecarleitao:mainfrom
jaychia wants to merge 3 commits intojorgecarleitao:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 83.06% 83.05% -0.01%
==========================================
Files 391 391
Lines 42889 42895 +6
==========================================
+ Hits 35626 35628 +2
- Misses 7263 7267 +4
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Also, no unit tests on this yet but would love pointers on how to best test this change. Should I add a new column in the files generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to parse any Parquet fields with
UnknownLogicalType as the ArrowNullDataType.