Merge pull request github#3510 from max-schaefer/cull-boring-queries

Approved by asgerf, esbena

Author: semmle-qlci

change-notes/1.25/analysis-javascript.md

@@ -43,6 +43,29 @@
 | Zip Slip (`js/zipslip`) | More results | This query now recognizes additional vulnerabilities. |
 | Unused property (`js/unused-property`) | Less results | This query no longer flags properties of objects that are operands of `yield` expressions. |
 
+The following low-precision queries are no longer run by default on LGTM (their results already were not displayed):
+
+  - `js/angular/dead-event-listener`
+  - `js/angular/unused-dependency`
+  - `js/conflicting-html-attribute`
+  - `js/useless-assignment-to-global`
+  - `js/too-many-parameters`
+  - `js/unused-property`
+  - `js/bitwise-sign-check`
+  - `js/comparison-of-identical-expressions`
+  - `js/misspelled-identifier`
+  - `js/jsdoc/malformed-param-tag`
+  - `js/jsdoc/unknown-parameter`
+  - `js/jsdoc/missing-parameter`
+  - `js/omitted-array-element`
+  - `js/ignored-setter-parameter`
+  - `js/json-in-javascript-file`
+  - `js/node/cyclic-import`
+  - `js/node/unused-npm-dependency`
+  - `js/single-run-loop`
+  - `js/nested-loops-with-same-variable`
+  - `js/return-outside-function`
+
 ## Changes to libraries
 
 * A library `semmle.javascript.explore.CallGraph` has been added to help write queries for exploring the call graph.

javascript/ql/src/AngularJS/DeadAngularJSEventListener.ql

@@ -3,7 +3,7 @@
  * @description An AngularJS event listener that listens for a non-existent event has no effect.
  * @kind problem
  * @problem.severity warning
- * @precision medium
+ * @precision low
  * @id js/angular/dead-event-listener
  * @tags correctness
  *       frameworks/angularjs

javascript/ql/src/AngularJS/UnusedAngularDependency.ql

@@ -3,7 +3,7 @@
  * @description Unused dependencies are confusing, and should be removed.
  * @kind problem
  * @problem.severity recommendation
- * @precision high
+ * @precision low
  * @id js/angular/unused-dependency
  * @tags maintainability
  *       frameworks/angularjs

javascript/ql/src/DOM/ConflictingAttributes.ql

@@ -8,7 +8,7 @@
  * @tags maintainability
  *       correctness
  *       external/cwe/cwe-758
- * @precision medium
+ * @precision low
  */
 
 import javascript

javascript/ql/src/Declarations/DeadStoreOfGlobal.ql

@@ -7,7 +7,7 @@
  * @tags maintainability
  *       correctness
  *       external/cwe/cwe-563
- * @precision medium
+ * @precision low
  */
 
 import javascript

javascript/ql/src/Declarations/TooManyParameters.ql

@@ -6,7 +6,7 @@
  * @id js/too-many-parameters
  * @tags testability
  *       readability
- * @precision high
+ * @precision low
  */
 
 import javascript

javascript/ql/src/Declarations/UnusedProperty.ql

@@ -5,7 +5,7 @@
  * @problem.severity recommendation
  * @id js/unused-property
  * @tags maintainability
- * @precision high
+ * @precision low
  */
 
 import javascript

javascript/ql/src/Expressions/BitwiseSignCheck.ql

@@ -6,7 +6,7 @@
  * @id js/bitwise-sign-check
  * @tags reliability
  *       correctness
- * @precision medium
+ * @precision low
  */
 
 import javascript

javascript/ql/src/Expressions/CompareIdenticalValues.ql

@@ -11,7 +11,7 @@
  *       convention
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571
- * @precision medium
+ * @precision low
  */
 
 import Clones

javascript/ql/src/Expressions/MisspelledIdentifier.ql

@@ -6,7 +6,7 @@
  * @id js/misspelled-identifier
  * @tags maintainability
  *       readability
- * @precision high
+ * @precision low
  */
 
 import Misspelling