add missing polarity check

erik-krogh · erik-krogh · commit 5898b4839194 · 2021-03-17T13:35:07.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/StandardLibrary.qll b/javascript/ql/src/semmle/javascript/StandardLibrary.qll
@@ -155,6 +155,7 @@ class StringReplaceCall extends DataFlow::MethodCallNode {
       DataFlow::Node ret
     |
       replacer = getCallback(1) and
+      guard.getOutcome() = test.getPolarity() and
       guard.getTest() = test and
       replacer.getParameter(0).flowsToExpr(test.getAnOperand()) and
       test.getAnOperand().getStringValue() = old and

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ class StringReplaceCall extends DataFlow::MethodCallNode {`
`155`	`155`	`DataFlow::Node ret`
`156`	`156`	`\|`
`157`	`157`	`replacer = getCallback(1) and`
	`158`	`+ guard.getOutcome() = test.getPolarity() and`
`158`	`159`	`guard.getTest() = test and`
`159`	`160`	`replacer.getParameter(0).flowsToExpr(test.getAnOperand()) and`
`160`	`161`	`test.getAnOperand().getStringValue() = old and`