Skip to content

Commit 68df802

Browse files
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <[email protected]>
1 parent 70081b6 commit 68df802

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/ql/src/semmle/code/java/security/MvelInjection.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/** Provides classes to reason about MVEL injection attacks. */
22

33
import java
4-
import semmle.code.java.dataflow.DataFlow
5-
import semmle.code.java.dataflow.ExternalFlow
4+
private import semmle.code.java.dataflow.DataFlow
5+
private import semmle.code.java.dataflow.ExternalFlow
66

77
/** A data flow sink for unvalidated user input that is used to construct MVEL expressions. */
88
abstract class MvelEvaluationSink extends DataFlow::Node { }
@@ -184,7 +184,7 @@ private predicate templateCompileStep(DataFlow::Node node1, DataFlow::Node node2
184184
private class MvelScriptEngineCompilationMethod extends Method {
185185
MvelScriptEngineCompilationMethod() {
186186
getDeclaringType() instanceof MvelScriptEngine and
187-
(hasName("compile") or hasName("compiledScript"))
187+
hasName(["compile", "compiledScript"])
188188
}
189189
}
190190

0 commit comments

Comments
 (0)