Update cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql

geoffw0 · MathiasVP · web-flow · commit 69468514f002 · 2021-05-07T16:26:42.000+01:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql b/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql
@@ -63,7 +63,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {
   exists(DataFlow::Node other, float p, float q |
     // linear access of `n`
     exprIsSubLeftOrLess(sub, other) and
-    linearAccess(other.asExpr(), n.asExpr(), p, q) and // other = p * e + q
+    linearAccess(other.asExpr(), n.asExpr(), p, q) and // other = p * n + q
     p >= 1 and
     q >= 0
   )

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {`
`63`	`63`	`exists(DataFlow::Node other, float p, float q \|`
`64`	`64`	// linear access of `n`
`65`	`65`	`exprIsSubLeftOrLess(sub, other) and`
`66`		`- linearAccess(other.asExpr(), n.asExpr(), p, q) and // other = p * e + q`
	`66`	`+ linearAccess(other.asExpr(), n.asExpr(), p, q) and // other = p * n + q`
`67`	`67`	`p >= 1 and`
`68`	`68`	`q >= 0`
`69`	`69`	`)`