Update cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql

geoffw0 · MathiasVP · web-flow · commit 91be483c5738 · 2021-05-07T16:26:36.000+01:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql b/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql
@@ -55,7 +55,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {
   exists(DataFlow::Node other, float p, float q |
     // linear access of `other`
     exprIsSubLeftOrLess(sub, other) and
-    linearAccess(n.asExpr(), other.asExpr(), p, q) and // e = p * other + q
+    linearAccess(n.asExpr(), other.asExpr(), p, q) and // n = p * other + q
     p <= 1 and
     q <= 0
   )

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ predicate exprIsSubLeftOrLess(SubExpr sub, DataFlow::Node n) {`
`55`	`55`	`exists(DataFlow::Node other, float p, float q \|`
`56`	`56`	// linear access of `other`
`57`	`57`	`exprIsSubLeftOrLess(sub, other) and`
`58`		`- linearAccess(n.asExpr(), other.asExpr(), p, q) and // e = p * other + q`
	`58`	`+ linearAccess(n.asExpr(), other.asExpr(), p, q) and // n = p * other + q`
`59`	`59`	`p <= 1 and`
`60`	`60`	`q <= 0`
`61`	`61`	`)`