Attempt to find response example based on request body #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelbyler
commented
Apr 18, 2023
| if(this.requestBody.content) { | ||
| let resultingExampleName; | ||
|
|
||
| Object.entries(this.requestBody.content).find(contentEntries => { |
Author
There was a problem hiding this comment.
I think in some places this project assumes application/json as the content type, if we're comfortable with that assumption then I think I can make this a little more simple here.
Author
|
I'll admit that I'm not great with js and appreciate any feedback you have on this PR. Thanks in advance! |
Author
|
@jormaechea do you have any feedback on this? Would love to use this feature, or an alternative if you have something in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to offer a solution to #66 this PR attempts to match the request body to a requestBody example and use the name of that example to find a corresponding response example. This could be used as an alternative to supplying a
Preferheader.