Merged
Conversation
Owner
|
That looks great 😎 . I'll review the code next week, it looks good at first sight. |
Collaborator
Author
|
Later on I want to try using for loops, instead of Would you recommend doing it here or testing afterwards in a different PR to compare performance? |
Collaborator
Author
Owner
|
Very nice! Good idea to utilize the knowledge about not needing to provide the index in the callback! |
Owner
|
Published now in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi,
This is a way to increase performance of map and forEach when iterating over arrays. The main improvement in speed is by cloning the index only for the callback. Includes an argument called skip index that avoids the costly iteration over an index.
Implements a naive skip zeros in
collection.