Skip to content

Comments

Refactor DenseMatrix._forEach#3403

Merged
josdejong merged 5 commits intodevelopfrom
Refactor-DenseMatrix._forEach
Feb 27, 2025
Merged

Refactor DenseMatrix._forEach#3403
josdejong merged 5 commits intodevelopfrom
Refactor-DenseMatrix._forEach

Conversation

@dvd101x
Copy link
Collaborator

@dvd101x dvd101x commented Feb 22, 2025

Hi,

This is a refactor of DenseMatrix._forEach method without affecting performance.

Unknown-4

This is in preparation for a non indexed version of that method.

@dvd101x
Copy link
Collaborator Author

dvd101x commented Feb 23, 2025

BTW this is only a suggestion and not necessary to make the non indexed version.

@josdejong
Copy link
Owner

That is a neat simplification of the code! Nice.

The chart that shows benchmarks with the map function, but I think that is unrelated to the changes in _forEach. Can you check whether the performance of forEach remains the same?

@dvd101x
Copy link
Collaborator Author

dvd101x commented Feb 25, 2025

Hi. Yes of course. Currently DenseMatrix._forEach is used in both DenseMatrix.map and DenseMatrix.forEach. I will update the chart with both.

@dvd101x
Copy link
Collaborator Author

dvd101x commented Feb 25, 2025

Here is the chart with both benchmarks.

refactor

@josdejong
Copy link
Owner

Hi. Yes of course. Currently DenseMatrix._forEach is used in both DenseMatrix.map and DenseMatrix.forEach. I will update the chart with both.

Ah, clear. Thanks!

@josdejong josdejong merged commit 8e528f9 into develop Feb 27, 2025
15 checks passed
@josdejong josdejong deleted the Refactor-DenseMatrix._forEach branch February 27, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants