chore: update matrix documentation to align with v15#3591
Merged
gwhitney merged 7 commits intojosdejong:developfrom Nov 11, 2025
Merged
chore: update matrix documentation to align with v15#3591gwhitney merged 7 commits intojosdejong:developfrom
gwhitney merged 7 commits intojosdejong:developfrom
Conversation
gwhitney
requested changes
Nov 11, 2025
Collaborator
gwhitney
left a comment
gwhitney
left a comment
There was a problem hiding this comment.
Thanks so much for attending to a persnickety little issue like this one! Much appreciated. Just a few minor layout comments and then we'll get this merged.
orelbn
commented
Nov 11, 2025
Contributor
Author
Thanks for the review! addressed your comments, let me know if there is anything else. |
gwhitney
approved these changes
Nov 11, 2025
Collaborator
gwhitney
left a comment
gwhitney
left a comment
There was a problem hiding this comment.
Looks good now. Thanks!
Owner
|
Thanks Orel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3565
Description
Updates matricies documentation with changes outlined in the issue referenced above.
Tests
The functionality is already verified in:
test/unit-tests/function/arithmetic/add.test.js> should add a scalar and a matrix correctlytest/unit-tests/function/matrix/size.test.js