Skip to content

Comments

Fix: Add missing nullishDependencies TypeScript declaration#3601

Merged
josdejong merged 1 commit intojosdejong:developfrom
Ayo1984:fix/ts-nullish-dependencies-type
Nov 26, 2025
Merged

Fix: Add missing nullishDependencies TypeScript declaration#3601
josdejong merged 1 commit intojosdejong:developfrom
Ayo1984:fix/ts-nullish-dependencies-type

Conversation

@Ayo1984
Copy link
Contributor

@Ayo1984 Ayo1984 commented Nov 24, 2025

This PR adds the missing nullishDependencies export to index.d.ts.
The JavaScript bundle correctly exports this dependency factory, but the TypeScript definition file does not declare it, causing a compile-time error

Resolves #3597

@josdejong
Copy link
Owner

Thanks @Ayo1984 for working out the missing type definitions!

@josdejong josdejong merged commit 6545dcd into josdejong:develop Nov 26, 2025
8 checks passed
josdejong added a commit that referenced this pull request Dec 10, 2025
* fix: #3597 added nullish type definitions (#3601)

* chore: update HISTORY.md and AUTHORS

* docs: describe that `setDistinct` sorts the elements (see #3602)

* [Issue-3602] - fixing setDistinct  order

* Reverting formatting

* fixing formatting

* fixing test cases and logic

---------

Co-authored-by: Ayomide Bamigbade <iamtryve@gmail.com>
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript declarations/tests for nullish missing

2 participants