Skip to content

Comments

[BREAKING] Fix #3602 let setDistinct keep the original order#3603

Merged
josdejong merged 7 commits intojosdejong:v16from
dhimansachit:Issue-3602
Dec 10, 2025
Merged

[BREAKING] Fix #3602 let setDistinct keep the original order#3603
josdejong merged 7 commits intojosdejong:v16from
dhimansachit:Issue-3602

Conversation

@dhimansachit
Copy link

image

Tests passing

@josdejong
Copy link
Owner

Thanks @dhimansachit for working out a solution with tests!

Can you please undo the formatting changes in the file? It's hard to see what actually changed.

@dhimansachit
Copy link
Author

Thanks @dhimansachit for working out a solution with tests!

Can you please undo the formatting changes in the file? It's hard to see what actually changed.

Hi @josdejong reverted the formatting changes. Can you please review once now?

Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @dhimansachit ! This looks good 👌

I made one inline remark, can you have a look at that?

@josdejong
Copy link
Owner

I see that some unit tests are failing now, I guess those are the existing unit tests that now return a differing order.

@josdejong josdejong changed the title [Issue-3602] - fixing setDistinct order [BREAKING] Fix #3602 let setDistinct keep the original order Nov 28, 2025
@josdejong josdejong changed the base branch from develop to v16 November 28, 2025 13:19
@josdejong josdejong added this to the v16 milestone Nov 28, 2025
@dhimansachit
Copy link
Author

I see that some unit tests are failing now, I guess those are the existing unit tests that now return a differing order.

Sorry, my bad. Didn't update the previous test. Updated now in the latest commit.

@josdejong
Copy link
Owner

Thanks @dhimansachit !

@josdejong josdejong merged commit 8a9e1be into josdejong:v16 Dec 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants