[BREAKING] Fix #3602 let setDistinct keep the original order#3603
[BREAKING] Fix #3602 let setDistinct keep the original order#3603josdejong merged 7 commits intojosdejong:v16from
Conversation
|
Thanks @dhimansachit for working out a solution with tests! Can you please undo the formatting changes in the file? It's hard to see what actually changed. |
Hi @josdejong reverted the formatting changes. Can you please review once now? |
josdejong
left a comment
There was a problem hiding this comment.
Thanks for the update @dhimansachit ! This looks good 👌
I made one inline remark, can you have a look at that?
|
I see that some unit tests are failing now, I guess those are the existing unit tests that now return a differing order. |
Sorry, my bad. Didn't update the previous test. Updated now in the latest commit. |
|
Thanks @dhimansachit ! |
Tests passing