Open
Conversation
Owner
|
@pmq sounds interesting, definitely interested in merging this functionality. |
Owner
|
@pmq is this complete? or still waiting to submit more? |
Contributor
Author
|
@josebalius I'm waiting to push this into production for us, and see if the users complain :) It should only be a few days. Two questions though, to adapt the PR :
|
Contributor
Author
|
@josebalius I didn't forget this PR - right now we're running this and it seems OK. The two questions still stand, but if you want to review as-is, it's also fine for me. Let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jose,
First of all, thanks for ngReactGrid, it works well. We needed a way to be able to specify our custom sort on some columns, hence this first draft. Before we go further on this (the current PR is crude), just wanted to know your opinion on this feature. Would there be enough interest to warrant merging at some point?
Thanks.