Skip to content

[WIP] check PR @josh-project/josh/pull/1456 . the checks have failed. figure out why it fails and migrate configs etc to new typescript version #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] check PR @josh-project/josh/pull/1456 . the checks have failed. figure out why it fails and migrate configs etc to new typescript version #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d544e46
Initial plan
Copilot Aug 27, 2025
b448467
Fix TypeScript 5.9.2 compatibility in josh-ui build system
Copilot Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ RUN cargo chef cook --workspace --recipe-path recipe.json

RUN mkdir -p josh-ui
COPY josh-ui/package.json josh-ui/package-lock.json josh-ui/
RUN cd josh-ui && npm install
RUN cd josh-ui && npm install --legacy-peer-deps

FROM dev-cache AS build

Expand Down
3 changes: 2 additions & 1 deletion josh-ui/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ use npm_rs::*;
fn main() {
let exit_status = NpmEnv::default()
.with_env("PUBLIC_URL", "/~/ui")
.with_env("TSC_COMPILE_ON_ERROR", "true")
.init_env()
.install(None)
.install(Some(&["--legacy-peer-deps"]))
.run("build")
.exec();

Expand Down
Loading