Add computed filter resolver support #1494
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add plumbing for computed filters Introduce a ComputedFilter hook on transactions so a `:computed` filter can be resolved per commit, cached, and have its metadata recorded for reverse lookups. Teach the history helpers to consult that metadata when finding original commits or unapplied filters, returning clear errors when the resolver or its records are missing. Extend the parser and pretty-printer to understand `:computed` (with optional arguments), and cover the resolver lifecycle, caching, and failure modes with new tests that rely on a tempfile-backed repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plumbing for computed filters
Introduce a ComputedFilter hook on transactions so a
:computedfilter can be resolved per commit, cached, and have its metadata recorded for reverse lookups. Teach the history helpers to consult that metadata when finding original commits or unapplied filters, returning clear errors when the resolver or its records are missing.Extend the parser and pretty-printer to understand
:computed(with optional arguments), and cover the resolver lifecycle, caching, and failure modes with new tests that rely on a tempfile-backed repository.