deps: update outdated packages and fix Dependabot configuration#20
Conversation
Summary of ChangesHello @joshsmithxrm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's health and security by updating several critical dependencies and significantly improving the automated dependency management system. The changes ensure that the project benefits from the latest features, security patches, and a more streamlined process for future dependency updates, addressing previous limitations in how Dependabot detected and proposed changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully updates several outdated packages, including an important security fix for Microsoft.PowerPlatform.Dataverse.Client and a move to a stable release for System.CommandLine. The updates to the test infrastructure are also welcome. The core of this PR is the much-improved Dependabot configuration, which correctly adds versioning-strategy: increase to handle floating versions and introduces dependency grouping to reduce pull request noise. The changes are logical and well-documented. I have one minor suggestion regarding the CHANGELOG.md file to improve its structure and readability.
There was a problem hiding this comment.
Pull request overview
This PR attempts to update outdated packages for security and stability improvements, and enhance the Dependabot configuration to better handle floating version updates. However, the PR contains critical issues with nonexistent package versions that will prevent the build from succeeding.
Key changes attempted:
- Update
Microsoft.PowerPlatform.Dataverse.Clientfrom1.1.*to1.2.*(valid) - Update
System.CommandLinefrom beta to stable2.0.1(valid) - Update test infrastructure packages (invalid versions specified)
- Enhance Dependabot configuration with versioning strategy and dependency grouping
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/PPDS.Plugins.Tests/PPDS.Plugins.Tests.csproj |
Updates test package versions (nonexistent versions specified) |
tests/PPDS.Migration.Cli.Tests/PPDS.Migration.Cli.Tests.csproj |
Updates test package versions (nonexistent versions specified) |
tests/PPDS.Dataverse.Tests/PPDS.Dataverse.Tests.csproj |
Updates test package versions (nonexistent versions specified) |
src/PPDS.Migration.Cli/PPDS.Migration.Cli.csproj |
Updates System.CommandLine to stable release 2.0.1 (valid) |
src/PPDS.Dataverse/PPDS.Dataverse.csproj |
Updates Microsoft.PowerPlatform.Dataverse.Client to 1.2.* (valid) |
CHANGELOG.md |
Documents the package updates with incorrect version numbers |
.github/dependabot.yml |
Adds versioning strategy, dependency grouping, and increases PR limit |
Critical Issue: The test package versions specified (Microsoft.NET.Test.Sdk 18.0.1, xunit 2.9.3, xunit.runner.visualstudio 3.0.2) do not exist and will cause build failures. These need to be corrected before the PR can be merged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Security updates: - Microsoft.PowerPlatform.Dataverse.Client: 1.1.* → 1.2.* (CVE-2022-26907) Test infrastructure updates: - Microsoft.NET.Test.Sdk: 17.8.0 → 18.0.1 - xunit: 2.6.4 → 2.9.3 - xunit.runner.visualstudio: 2.5.6 → 3.0.2 Dependabot improvements: - Added versioning-strategy: increase for floating version bumps - Added dependency grouping to reduce PR noise - Increased PR limit from 5 to 10 Root cause: Floating versions (e.g., 1.1.*) prevented Dependabot from suggesting minor/major version bumps. The versioning-strategy setting addresses this going forward. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
755ad2d to
ccff3e6
Compare
Bumps [madge](https://github.com/pahen/madge) from 7.0.0 to 8.0.0. - [Changelog](https://github.com/pahen/madge/blob/master/CHANGELOG.md) - [Commits](pahen/madge@v7.0.0...v8.0.0) --- updated-dependencies: - dependency-name: madge dependency-version: 8.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
Microsoft.PowerPlatform.Dataverse.Clientfrom1.1.*to1.2.*(includes CVE-2022-26907 fix)Microsoft.NET.Test.Sdk18.0.1,xunit2.9.3,xunit.runner.visualstudio3.0.2Root Cause Analysis: Why Dependabot Missed These
Primary Issue: Floating Versions
Packages using wildcard versions like
1.1.*,4.20.*,8.0.*are treated by Dependabot as version constraints, not specifications. When you specify1.1.*, Dependabot interprets this as "I want any 1.1.x version" and considers you up-to-date as long as any 1.1.x exists—it will NOT suggest1.2.*because that changes the constraint itself.Secondary Issues:
Dependabot Configuration Fixes
versioning-strategyincreaseopen-pull-requests-limitgroupsTest Plan
🤖 Generated with Claude Code