-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: distinguish user-provided mapping from auto-created default in summary #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ummary Check userMappingFile (the CLI argument) instead of importOptions.UserMappings to determine if the user provided a mapping file. When --strip-owner-fields is used without --user-mapping, the code creates an auto-default mapping that should not report "userMappingProvided": true. Closes #202 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Summary of ChangesHello @joshsmithxrm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the import summary incorrectly indicated that a user mapping file was provided, even when only an auto-generated default mapping was in use. The change ensures that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses an issue where the import summary would incorrectly report that a user mapping file was provided when an auto-created default mapping was used with --strip-owner-fields. The fix, which involves checking the userMappingFile argument directly instead of the populated importOptions.UserMappings property, is clear, correct, and effectively distinguishes between a user-provided mapping and an internally generated one. The change is well-contained and improves the accuracy of the import summary. I have no further comments, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the import summary incorrectly reports userMappingProvided: true when --strip-owner-fields is used without --user-mapping. The auto-created default mapping should not be considered as user-provided.
- Changes the summary field
UserMappingProvidedto check the CLI argumentuserMappingFileinstead of the processedimportOptions.UserMappingsobject
Summary
userMappingFile(the CLI argument) instead ofimportOptions.UserMappingsto determine if the user provided a mapping file--strip-owner-fieldsis used without--user-mapping, the code creates an auto-default mapping that should not report"userMappingProvided": trueTest plan
Closes #202
🤖 Generated with Claude Code